[Unity] Extend EliminateCommonSubexpr to operate on relax::Expr #15815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the `EliminateCommonSubexpr` utility could only apply to `relax::Function` instances. This commit extends the allowed usage to apply to any `relax::Expr` that contains variable bindings. This is only included as an internal utility within the C++ implementation, and is not currently exposed for external use.
slyubomirsky
approved these changes
Sep 26, 2023
Contributor
slyubomirsky
left a comment
slyubomirsky
left a comment
There was a problem hiding this comment.
Great change, thank you very much.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the
EliminateCommonSubexprutility could only apply torelax::Functioninstances. This commit extends the allowed usage to apply to anyrelax::Exprthat contains variable bindings. This is only included as an internal utility within the C++ implementation, and is not currently exposed for external use.