[Graph Tuner]Core Functionality for Graph Tuner #1586
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinthesun
force-pushed
the
GraphTuner
branch
from
86d33bd to
1ab9a34
Compare
kevinthesun
force-pushed
the
GraphTuner
branch
2 times, most recently
from
3a58ad6 to
7512b6e
Compare
kevinthesun
force-pushed
the
GraphTuner
branch
2 times, most recently
from
9290fff to
03d14c7
Compare
added 11 commits
September 4, 2018 11:12
kevinthesun
force-pushed
the
GraphTuner
branch
from
03d14c7 to
9589d3d
Compare
2 tasks
liangfu
requested changes
Sep 29, 2018
| @@ -0,0 +1,410 @@ | |||
| # pylint: disable=too-many-arguments,too-many-locals,too-many-statements,too-many-instance-attributes,too-many-branches,too-many-nested-blocks | |||
Member
There was a problem hiding this comment.
Please don't put these on top of a file. Move them under specific classes or functions, where pylint should be disabled for a certain reason.
| @@ -0,0 +1,198 @@ | |||
| # pylint: disable=import-error,too-many-locals,too-many-statements,too-many-branches,arguments-differ,unused-variable | |||
Member
There was a problem hiding this comment.
Please move them under specific classes or functions, where pylint should be disabled for a certain reason.
Member
|
close for now due to inactive status, feel free to reopen when we bring in new changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is core function for graph tuner.
Detailed information and RFC: #1585
@tqchen @yidawang @yzhliu @merrymercy @Laurawly