Skip to content

[Unity] Replace relax_vm/memory_manager with memory/memory_manager #15882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tqchen merged 4 commits into from
Oct 31, 2023
Merged

[Unity] Replace relax_vm/memory_manager with memory/memory_manager #15882

tqchen merged 4 commits into from
Oct 31, 2023

Conversation

@yongwww
Copy link
Member

@yongwww yongwww commented Oct 6, 2023 •
edited
Loading

We can unify the runtime/relax_vm/memory_manager and runtime/memory/memory_manager by replacing the former with the latter.

@yongwww yongwww changed the title [Unity] Replace relax_vm/memory_manager with memory/memory_manager [Do Not Merge] [Do Not Merge][Unity] Replace relax_vm/memory_manager with memory/memory_manager Oct 6, 2023
@yongwww yongwww force-pushed the unify_memory_manager branch from f2093dd to 3d428d3 Compare October 10, 2023 23:02
yongwww
yongwww commented Oct 11, 2023
View reviewed changes
@yongwww yongwww changed the title [Do Not Merge][Unity] Replace relax_vm/memory_manager with memory/memory_manager [Unity] Replace relax_vm/memory_manager with memory/memory_manager Oct 11, 2023
@yongwww
Copy link
Member Author

yongwww commented Oct 11, 2023 •
edited
Loading

cc: @tqchen @srkreddy1238 @yelite

@yongwww yongwww force-pushed the unify_memory_manager branch from 23037c7 to e429cec Compare October 12, 2023 00:56
@yongwww yongwww marked this pull request as draft October 13, 2023 01:46
srkreddy1238
srkreddy1238 approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@srkreddy1238 srkreddy1238 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yongwww yongwww force-pushed the unify_memory_manager branch from e429cec to b60ead1 Compare October 31, 2023 01:28
@yongwww yongwww marked this pull request as ready for review October 31, 2023 01:28
@tqchen tqchen merged commit a9c81a7 into apache:unity Oct 31, 2023
@Lunderberg
Copy link
Contributor

Lunderberg commented Nov 6, 2023 •
edited
Loading

This change has resulted in breakage here in MLC-LLM, due to the removal of the "vm.builtin.memory_manager.clear" packed func. Is there a renamed version of this function?

Edit: Looks like today's merge from main into unity pulled in #16066, which resolves this breakage.

@yongwww yongwww deleted the unify_memory_manager branch November 7, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tqchen tqchen tqchen approved these changes

@srkreddy1238 srkreddy1238 srkreddy1238 approved these changes

+1 more reviewer

@yelite yelite yelite approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yongwww @Lunderberg @tqchen @yelite @srkreddy1238