Skip to content

[Unity][TVMScript] Avoid dangling reference when printing Call attrs #15923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
masahi merged 1 commit into from
Oct 13, 2023
Merged

[Unity][TVMScript] Avoid dangling reference when printing Call attrs #15923

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/script/printer/relax/call.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@ namespace printer {

class AttrPrinter : public tvm::AttrVisitor {
public:
explicit AttrPrinter(const ObjectPath& p, const IRDocsifier& d, Array<String>* keys,
explicit AttrPrinter(ObjectPath p, const IRDocsifier& d, Array<String>* keys,
Array<ExprDoc>* values)
: p(p), d(d), keys(keys), values(values) {}
: p(std::move(p)), d(d), keys(keys), values(values) {}

void Visit(const char* key, double* value) final {
keys->push_back(key);
Expand Down Expand Up @@ -79,7 +79,7 @@ class AttrPrinter : public tvm::AttrVisitor {
LOG(FATAL) << "TypeError: NDArray is not allowed in Attrs";
}

const ObjectPath& p;
ObjectPath p;
const IRDocsifier& d;
Array<String>* keys;
Array<ExprDoc>* values;
Expand Down