[FFI][Python] Handle error propagation when line number is missing #15955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the FFI error propagation in Python assumed that any stack frame with a known file name also had a known line number. This commit updates the error propagation to instead check if a known line number is present. Closes apache#15880.
Contributor
Author
|
@jinhongyii I have this PR marked as a draft, to prevent merging prior to your confirmation of its effect. |
Lunderberg
force-pushed
the
ffi_check_if_line_number_is_known
branch
from
61bf726 to
68603cb
Compare
Member
|
Hey do you think it's ready? I met the same issue and this one seems a good fix to me |
Contributor
Author
|
@junrushao I think it is. Since you ran into the same issue and can verify that the fix resolves it, I'm marking it as ready for review. (I wasn't able to reproduce the original error, so I was waiting for confirmation from somebody who could.) |
Lunderberg
changed the title
junrushao
approved these changes
Oct 30, 2023
Member
junrushao
left a comment
junrushao
left a comment
There was a problem hiding this comment.
Cannot wait to get it merged!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the FFI error propagation in Python assumed that any stack frame with a known file name also had a known line number. This commit updates the error propagation to instead check if a known line number is present.
Closes #15880.