[CMake] Fix order of GNUInstallDirs module #15966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In CMakeLists.txt, the variables CMAKE_INSTALL_<dir> are referenced before the execution of GNUInstallDirs module. This order is incorrect as the variables are defined by the GNUInstallDirs module. Since the variables are undefined, INTERFACE_INCLUDE_DIRECTORIES property is not set in the tvmTargets.cmake. This causes external applications based on TVM unable to find TVM runtime headers. Signed-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
cbalint13
approved these changes
Oct 23, 2023
Contributor
cbalint13
left a comment
cbalint13
left a comment
There was a problem hiding this comment.
LGTM thanks @syalavarthi !
echuraev
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In CMakeLists.txt, the variables CMAKE_INSTALL_
are referenced before the execution of GNUInstallDirs module. This order is incorrect as the variables are defined by the GNUInstallDirs module.Since the variables are undefined, INTERFACE_INCLUDE_DIRECTORIES property is not set in the tvmTargets.cmake. This causes external applications based on TVM unable to find TVM runtime headers.