[CI][ADRENO] Enhancements to Adreno specific CI utils #15991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RPC seem to be hanging while running bunch of tests with in single session. This enables running them individually. Also we don't need rerun with in same session that leads to hang some times. Adding PLATFORM which is needed for run_pytest to summarize the failures.
yongwww
reviewed
Oct 31, 2023
| # Test TVM | ||
| make cython3 | ||
|
|
||
| # The RPC to remote Android device has issue of hang after few tests with in CI environments. |
Member
There was a problem hiding this comment.
Thanks for looking into this! This workaround should be good if it does not significantly increase the overall CI time. It would be great to identify the root cause of the hang issue as well.
Contributor
Author
There was a problem hiding this comment.
True, individual runs increase the times significantly that too running on remote device.
I did a bit of a debug on this and it waits infinitely on socket read on host where as device has nothing to write.
Didn't perused further at the moment. I will definitely revisit the RPC issue a bit later.
Member
Contributor
Author
|
@yongwww Can u review and merge this ? We have few follow up PR's on this. The RPC issue I will investigate a little later. |
yongwww
approved these changes
Nov 27, 2023
Member
|
@srkreddy1238 it is landed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RPC seem to be hanging while running bunch of tests with in single session. This enables running them individually.
Also we don't need rerun with in same session that leads to hang some times. Adding PLATFORM which is needed for run_pytest to summarize the failures.