[Pylint] fix pylint issues from test_random to test_tedd #16065
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hzfengsy
reviewed
Nov 5, 2023
tests/python/contrib/test_tedd.py
Outdated
| B = te.compute((n, m, l), lambda bi, bj, bk: A[bi, bj, bk] + 1, name="B") | ||
| r = te.reduce_axis((0, m), "r") | ||
| C = te.compute( | ||
| op_l = te.var("op_l") |
Member
There was a problem hiding this comment.
IMO, it's good to keep those concise names. I guess these names can pass the pylint through the pylintrc.
Member
Author
There was a problem hiding this comment.
Thanks. I will change them later.
Member
Author
There was a problem hiding this comment.
@Hzfengsy Well, those concise names would trigger C0103(invalid-name). Like the var "l", the info is Variable name "l" doesn't conform to '[a-z_][a-z0-9_]{2,30}$' pattern. Is it better to use pylint: disable=invalid-name ?
Member
There was a problem hiding this comment.
Sorry for the late reply, please feel free to disable invalid-name for the whole file
tests/python/contrib/test_tedd.py
Outdated
| input_a = te.placeholder((n, m), name="input_a") | ||
| k = te.reduce_axis((0, m), "k") | ||
| B = te.compute((n,), lambda i: te.sum(A[i, k], axis=k), name="B") | ||
| input_b = te.compute((n,), lambda i: te.sum(input_a[i, k], axis=k), name="input_b") |
Hzfengsy
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #11414 , I fixed pylint issues for test_random, test_rocblas, test_rpc_proxy, test_rpc_server_device, test_rpc_tracker, test_sort, test_sparse, test_tedd in this PR.