[Support] Add Interrupt Handling in Pipe #16234
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqchen
requested changes
Dec 13, 2023
| /*! | ||
| * \return last error of socket operation | ||
| */ | ||
| static int GetLastErrorCode() { |
Member
There was a problem hiding this comment.
This needs to be passed as a second template function parameter to RetryCallOnEINTR
Member
There was a problem hiding this comment.
We need specialized function in socket and pipe
For socket it should be WSAGetLastError() in windows, for pipe it should be GetLastError()
| @@ -67,8 +69,8 @@ class Pipe : public dmlc::Stream { | |||
| ICHECK(ReadFile(handle_, static_cast<TCHAR*>(ptr), size, &nread, nullptr)) | |||
Member
There was a problem hiding this comment.
on windows, create a lambda function that follows the same convention
auto fread = [&]() {
if (!ReadFile(handle_, static_cast<TCHAR*>(ptr), size, &nread, nullptr)) return -1;
if (nread != nwrite) return -1;
return nread;
};
tqchen
reviewed
Dec 14, 2023
| * \file err_handling.h | ||
| * \brief Common error handling functions for socket.h and pipe.h | ||
| */ | ||
| #ifndef TVM_SUPPORT_ERR_HANDLING_H_ |
Member
There was a problem hiding this comment.
errno_handling (specific to handle error number)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc. @tqchen @LeshengJin