[Relay][TOPI] Add support for group_conv1d_transpose_ncw for generic #16248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quic-sanirudh
approved these changes
Dec 17, 2023
Contributor
quic-sanirudh
left a comment
quic-sanirudh
left a comment
There was a problem hiding this comment.
There seems to be quite a bit of code overlap between this function and the conv1d_transpose_ncw (groups=1) version. Could we try and avoid the duplication by extracting relevant parts into a common function.
This is just a suggestion as I feel in general it's always good to avoid code duplication.
quic-sanirudh
approved these changes
Dec 18, 2023
Contributor
quic-sanirudh
left a comment
quic-sanirudh
left a comment
There was a problem hiding this comment.
LGTM, Thanks for the changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
group_conv1d_transpose_ncwgeneric.