[BugFix] Update pillow usage #16269
Merged
[BugFix] Update pillow usage #16269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
quic-sanirudh
left a comment
quic-sanirudh
left a comment
There was a problem hiding this comment.
LGTM, but could this affect backward compatibility for folks who don't use the latest Pillow version?
Should we perhaps add a version specific check to verify whether the textlength function exists before using it?
Contributor
|
The |
quic-sanirudh
approved these changes
Jan 2, 2024
Contributor
quic-sanirudh
left a comment
quic-sanirudh
left a comment
There was a problem hiding this comment.
LGTM, Thanks. As discussed in the comments, since the textlength function was added in 8.0 version almost 3 years ago and since this is just a testing function, I'm fine with not adding any version specific checks for this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request for Yolo detection boxes helper functions.
Tracking issue: #16268
Update to use a replacement function for the removed function so that it can be executed in Pillow version 10 or later.