Skip to content

Conversation

@liushengjiezj
Copy link

@liushengjiezj liushengjiezj commented Feb 4, 2024

Fix issue #16510
Please help to review this patch, thanks @Hzfengsy @Johnson9009

@liushengjiezj liushengjiezj marked this pull request as draft February 4, 2024 02:30
@liushengjiezj liushengjiezj marked this pull request as ready for review February 4, 2024 02:33
@Johnson9009
Copy link
Contributor

@tqchen @Hzfengsy It seems we need involve more resources to fix these failed cases.

@Hzfengsy
Copy link
Member

Hzfengsy commented Feb 5, 2024

Thanks for the PR. I'm working on the ut fix. I would open a new PR including:

  1. bash fix in this PR
  2. ut fixes to ensure all test pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants