[Fix][Arith] Fix canonical simplification of LE #16704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR apache#15471 enhances the simplification for LE, while missed a case where the upper bound `kPosInf` is divisible by a factor. Therefore, prior to this PR, when simplifying `x * 1024 + y < z * 7168`, it will fails with the error message ``` InternalError: Check failed: value < 1LL << (dtype.bits() - 1) (8589934591 vs. 2147483648) : ValueError: Literal value 8589934591 exceeds maximum of int32 ``` This is just because the upper bound 7 here divides `kPosInf` the maximum value of int64, which passes an "if" condition in apache#15471 unexpectedly. This PR fixes the issue.
MasterJH5574
force-pushed
the
tvm-dev/2024-03-12-arith-le
branch
from
4bbca4b to
2b66744
Compare
Member
|
Great fix! |
tqchen
approved these changes
Mar 12, 2024
thaisacs
pushed a commit
to thaisacs/tvm
that referenced
this pull request
Apr 3, 2024
PR apache#15471 enhances the simplification for LE, while missed a case where the upper bound `kPosInf` is divisible by a factor. Therefore, prior to this PR, when simplifying `x * 1024 + y < z * 7168`, it will fails with the error message ``` InternalError: Check failed: value < 1LL << (dtype.bits() - 1) (8589934591 vs. 2147483648) : ValueError: Literal value 8589934591 exceeds maximum of int32 ``` This is just because the upper bound 7 here divides `kPosInf` the maximum value of int64, which passes an "if" condition in apache#15471 unexpectedly. This PR fixes the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #15471 enhances the simplification for LE, while missed a case where the upper bound
kPosInfis divisible by a factor. Therefore, prior to this PR, when simplifyingx * 1024 + y < z * 7168, it will fails with the error messageThis is just because the upper bound 7 here divides
kPosInfthe maximum value of int64, which passes an "if" condition in #15471 unexpectedly.This PR fixes the issue.