[Hotfix] Revert driver API pass ordering that breaks MLC, mark failing test #16770
Conversation
Lunderberg
left a comment
Lunderberg
left a comment
There was a problem hiding this comment.
Thank you for making the more targeted reversion, and for linking back to the discussions. Those links are always a big help in tracing back changes after the fact.
| assert generated_code == expected_cuda_script | ||
|
|
||
|
|
||
| @pytest.mark.skip( |
There was a problem hiding this comment.
I like the documentation, both to indicate what needs to be resolved in order to re-enable functionality, and where the existing discussions are
slyubomirsky
changed the title
|
Tianqi clarified that only the driver API pass ordering caused the MLC failures, so that's the only change being reverted here now. |
MasterJH5574
left a comment
MasterJH5574
left a comment
There was a problem hiding this comment.
Thanks so much @slyubomirsky @Lunderberg @tqchen. Just checked on my local side: this PR can fix the model compilation error.
|
The CI error looks to be spurious. We will have to retrigger it. |
|
@tvm-bot rerun |
…g test (apache#16770) * Revert changes that cause failures in MLC, mark and skip the failing tests * Restore changes unrelated to driver API reordering
4 participants
Following up from discussion in #16769, this is a smaller-scale reversion that patches the MLC build by reverting only the changes that broke it (the driver API pass reordering). However, these changes came from #16569 and were needed to fix failing tests. That test has been marked as skippable here but should be fixed along with MLC.