[Fix] Remove redundant "remove_all_unused" in IPC memory lowering #16771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasterJH5574
force-pushed
the
tvm-dev/2024-03-22-ipc-alloc-no-removal
branch
from
a6c7781 to
2e8ee7f
Compare
vinx13
approved these changes
Mar 22, 2024
This commit removes the redundant invocation of `remove_all_unused` function in the GPU IPC memory allocation lowering pass. This is because the pass only mutates one call at a time, and thus will not introduce new unused bindings.
MasterJH5574
force-pushed
the
tvm-dev/2024-03-22-ipc-alloc-no-removal
branch
from
2e8ee7f to
9882a9a
Compare
thaisacs
pushed a commit
to thaisacs/tvm
that referenced
this pull request
Apr 3, 2024
…ache#16771) This commit removes the redundant invocation of `remove_all_unused` function in the GPU IPC memory allocation lowering pass. This is because the pass only mutates one call at a time, and thus will not introduce new unused bindings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the redundant invocation of
remove_all_unusedfunction in the GPU IPC memory allocation lowering pass. This is because the pass only mutates one call at a time, and thus will not introduce new unused bindings.