[Relax] Provide well-formed output in transform.LazyGetInput
#16841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, symbolic variables inferred from the parameters were retained in the output function's `ret_struct_info`. This is ill-formed, as the parameters from which these symbolic variables are inferred are no longer part of the function signature. This commit updates `LazyGetInput` to use `EraseToWellDefined` to remove any symbolic variables from `ret_struct_info` that cannot be inferred from the remaining arguments.
Contributor
Author
|
@slyubomirsky This is the follow-up to #16798, which I ended up making much sooner than I had initially planned. |
slyubomirsky
approved these changes
Apr 4, 2024
Contributor
slyubomirsky
left a comment
slyubomirsky
left a comment
There was a problem hiding this comment.
Good catch; I didn't realize that we were losing shape vars from the signature
Contributor
Author
Thank you. This ended up resulting from some debugging I did with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, symbolic variables inferred from the parameters were retained in the output function's
ret_struct_info. This is ill-formed, as the parameters from which these symbolic variables are inferred are no longer part of the function signature.This commit updates
LazyGetInputto useEraseToWellDefinedto remove any symbolic variables fromret_struct_infothat cannot be inferred from the remaining arguments.