[Relax] Prevent to generate duplicate func in dispatch_sort_scan #16904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hzfengsy
force-pushed
the
fix_dispatch_sort_duplicate_func
branch
2 times, most recently
from
aaa7b45 to
e8a380c
Compare
The current pass would generate multiple PrimFuncs even if they are structural equal, which is because `bb.update_func` will not check whether the new func is already in the list. This PR apply dlight at the end of the dispatching instead of after every function.
Hzfengsy
force-pushed
the
fix_dispatch_sort_duplicate_func
branch
from
e8a380c to
f386132
Compare
tqchen
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current pass would generate multiple PrimFuncs even if they are structural equal, which is because
bb.update_funcwill not check whether the new func is already in the list.This PR apply dlight at the end of the dispatching instead of after every function.
cc @yongwww @vinx13