Skip to content

[CI] Enable unittests for disco #16975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Lunderberg wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[CI] Enable unittests for disco #16975

Lunderberg wants to merge 1 commit into from

Conversation

@Lunderberg
Copy link
Contributor

@Lunderberg Lunderberg commented May 7, 2024

The refactor of the unittest folder in #16110 did not include the tests/python/disco folder in the list of folders to run in CI.

@Lunderberg
Copy link
Contributor Author

Lunderberg commented May 15, 2024

Looks like there's some failing tests, which seem to have crept in while the tests were disabled.

  • There is no tvm.testing.disco that can be imported. Looks like it should instead import the exec_worker to get the PackedFunc definitions from that file.

  • Ill-formed TIR, which is now validated when parsing TVMScript.

  • NCCL not currently installed in CI environment, and not all NCCL-dependent tests are marked with tvm.testing.requires_nccl.

@Lunderberg Lunderberg mentioned this pull request Jul 25, 2024
Merged
@Lunderberg
[CI] Enable unittests for disco
a27e748 
The refactor of the unittest folder in apache#16110 did not include the
`tests/python/disco` folder in the list of folders to run in CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yongwww yongwww yongwww approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Lunderberg @yongwww