[TOPI] Add dp4a intrinsic to CUDA #1707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinx13
force-pushed
the
topi/dp4a_intrin
branch
from
a4fa7f6 to
9eb96b9
Compare
vinx13
force-pushed
the
topi/dp4a_intrin
branch
from
9eb96b9 to
a17e5c7
Compare
tqchen
requested changes
Sep 12, 2018
| import tvm | ||
|
|
||
|
|
||
| def _intrin_dp4a_reduce(x_scope, y_scope, z_scope): |
Member
There was a problem hiding this comment.
let us put it under cuda/tensor_intrin.py and rename to dp4a
Member
Author
|
@tqchen I have renamed the filename and dp4a, please review. |
tqchen
requested changes
Sep 13, 2018
|
|
||
| Parameters | ||
| ---------- | ||
| x_scope: The storage scope of buffer for lhs |
Member
There was a problem hiding this comment.
add data type, see https://docs.tvm.ai/contribute/document.html#document-python
Member
There was a problem hiding this comment.
Maybe it makes sense to default everything to local
tqchen
requested changes
Sep 13, 2018
|
|
||
| Parameters | ||
| ---------- | ||
| x_scope: The storage scope of buffer for lhs |
Member
There was a problem hiding this comment.
Maybe it makes sense to default everything to local
tqchen
approved these changes
Sep 14, 2018
Member
|
Thanks @vinx13 this is now merged! |
tqchen
added
status: accepted
and removed
status: need update
FrozenGene
pushed a commit
to FrozenGene/tvm
that referenced
this pull request
Dec 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added dp4a intrinsic to TOPI, and refactored gemm_int8 recipe. And then I will send int8 conv2d using dp4a in the next PR.
cc @tqchen @merrymercy