[RPC] Raise error if server process terminated #17101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this PR, a local RPC server could crash without any indication in the main process. While typically this crash would cause an error in the main process due to the lack of a `RPCCode::kReturn` from the server, the delayed error can complicate debugging. This PR updates the local RPC server to raise an exception if the server process returns with a non-zero exit code.
yongwww
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, a local RPC server could crash without any indication in the main process. While typically this crash would cause an error in the main process due to the lack of a
RPCCode::kReturnfrom the server, the delayed error can complicate debugging.This PR updates the local RPC server to raise an exception if the server process returns with a non-zero exit code.