Skip to content

Use packaging.version.parse instead of distutils.version.LooseVersion #17173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tqchen merged 1 commit into from
Jul 19, 2024
Merged

Use packaging.version.parse instead of distutils.version.LooseVersion #17173

tqchen merged 1 commit into from
Jul 19, 2024

Conversation

@mshr-h
Copy link
Contributor

@mshr-h mshr-h commented Jul 18, 2024 •
edited
Loading

@mshr-h mshr-h mentioned this pull request Jul 18, 2024
Closed
5 tasks
@mshr-h mshr-h force-pushed the use-packaging-version branch from 3644782 to 12609f4 Compare July 18, 2024 10:43
@mshr-h mshr-h marked this pull request as ready for review July 18, 2024 12:47
@tqchen tqchen merged commit 3c7adfb into apache:main Jul 19, 2024
@mshr-h mshr-h deleted the use-packaging-version branch July 20, 2024 04:58
@ysh329 ysh329 mentioned this pull request Oct 16, 2024
Closed
@kurisu6912 kurisu6912 mentioned this pull request Sep 5, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tqchen tqchen tqchen approved these changes

@Hzfengsy Hzfengsy Awaiting requested review from Hzfengsy

@MasterJH5574 MasterJH5574 Awaiting requested review from MasterJH5574

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mshr-h @tqchen