Skip to content

[Transform][Relax] Handle is_group argument in IPC AllReduce #17201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tqchen merged 3 commits into from
Jul 31, 2024
Merged

[Transform][Relax] Handle is_group argument in IPC AllReduce #17201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9a019e8
[Transform][Relax] Handle `is_group` argument in IPC AllReduce
Lunderberg Jul 26, 2024
397a839
lint fix
Lunderberg Jul 26, 2024
15149f6
lint fix
Lunderberg Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions python/tvm/relax/transform/ipc_allreduce_rewrite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,8 @@ def visit_call_(self, call: relax.Call) -> None: # pylint: disable=arguments-re
# Return if the call is not a summation all-reduce.
return

assert len(call.args) == 3
allreduce_input = call.args[0]
assert len(call.args) == 4
allreduce_input, _strategy, _ingroup, allreduce_output = call.args
alloc_tensor = self.alloc_map.get(allreduce_input, None)
if alloc_tensor is None or alloc_tensor.args[3].value != "global":
# Return if the allocation of all-reduce input is not recorded,
Expand All @@ -113,9 +113,13 @@ def visit_call_(self, call: relax.Call) -> None: # pylint: disable=arguments-re
alloc_tensor.args[2],
relax.StringImm("ipc_memory"),
)

self.binding_replacement_map[call] = relax.Call(
relax.ExternFunc("runtime.disco.cuda_ipc.custom_allreduce"),
args=[call.args[0], relax.PrimValue(self.allreduce_strategy), call.args[2]],
# The "cuda_ipc.custom_allreduce" implementation does not
# yet support num_groups>1, and therefore does not use the
# `in_group` argument.
[allreduce_input, relax.PrimValue(self.allreduce_strategy), allreduce_output],
)


Expand Down
16 changes: 10 additions & 6 deletions tests/python/relax/test_transform_ipc_allreduce_rewrite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,9 @@ def main(shape: R.Shape(["m", "n"])): # type: ignore
alloc1: R.Tensor((m, n), dtype="float16") = R.builtin.alloc_tensor( # type: ignore
R.shape([m, n]), R.dtype("float16"), R.prim_value(0), R.str("global")
)
_: R.Object = R.call_packed("runtime.disco.allreduce", lv1, R.shape([0]), alloc1)
_: R.Object = R.call_packed(
"runtime.disco.allreduce", lv1, R.shape([0]), R.prim_value(True), alloc1
)
return alloc1

@I.ir_module
Expand Down Expand Up @@ -85,7 +87,9 @@ def main(shape: R.Shape(["m", "n"])): # type: ignore
alloc1: R.Tensor((m * n,), dtype="float16") = R.builtin.alloc_tensor( # type: ignore
R.shape([m * n]), R.dtype("float16"), R.prim_value(0), R.str("global")
)
_: R.Object = R.call_packed("runtime.disco.allreduce", lv1, R.shape([0]), alloc1)
_: R.Object = R.call_packed(
"runtime.disco.allreduce", lv1, R.shape([0]), R.prim_value(False), alloc1
)
return alloc1

@I.ir_module
Expand Down Expand Up @@ -137,7 +141,9 @@ def main(shape: R.Shape(["m", "n"])): # type: ignore
alloc1: R.Tensor((m, n), dtype="float16") = R.builtin.alloc_tensor( # type: ignore
R.shape([m, n]), R.dtype("float16"), R.prim_value(0), R.str("global")
)
_: R.Object = R.call_packed("runtime.disco.allreduce", lv1, R.shape([1]), alloc1)
_: R.Object = R.call_packed(
"runtime.disco.allreduce", lv1, R.shape([1]), R.prim_value(True), alloc1
)
return alloc1

allreduce_strategy = 1
Expand All @@ -146,6 +152,4 @@ def main(shape: R.Shape(["m", "n"])): # type: ignore


if __name__ == "__main__":
test_ipc_allreduce_rewrite()
test_ipc_allreduce_spread_along_reshape()
test_ipc_allreduce_skip_reducer_other_than_sum()
tvm.testing.main()