Skip to content

[Runtime Patch] Add AbortSignal to fetchWithCache in ArtifactCacheTemplate interface #17233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tqchen merged 1 commit into from
Aug 2, 2024
Merged

[Runtime Patch] Add AbortSignal to fetchWithCache in ArtifactCacheTemplate interface #17233

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion web/src/artifact_cache.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,12 @@ export interface ArtifactCacheTemplate {
* return the actual data object rather than the request. There are two options:
* 1. "json": returns equivalent to `fetch(url).json()`
* 2. "arraybuffer": returns equivalent to `fetch(url).arraybuffer()`
* @param signal: An optional AbortSignal allowing user to abort the fetching before its completion.
* @return The data object (i.e. users do not need to call `.json()` or `.arraybuffer()`).
*
* @note This is an async function.
*/
fetchWithCache(url: string, storetype?: string): Promise<any>;
fetchWithCache(url: string, storetype?: string, signal?: AbortSignal): Promise<any>;

/**
* Fetch data from url and add into cache. If already exists in cache, should return instantly.
Expand Down