Skip to content

[KVCache] Increase coalesce threshold #17280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MasterJH5574 merged 1 commit into from
Aug 17, 2024
Merged

[KVCache] Increase coalesce threshold #17280

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/runtime/relax_vm/paged_kv_cache.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1727,7 +1727,7 @@ class PagedAttentionKVCacheObj : public AttentionKVCacheObj {
qkv_data->dtype);
// Part 2. Split fused qkv and apply rotary embedding to q/k data.
f_split_rotary_(qkv_data, q_rope_position_map_view_, q_data, k_data, v_data,
rope_mode_ == RoPEMode::kNormal);
static_cast<int>(rope_mode_ == RoPEMode::kNormal));

// Part 3. Append k/v data to kv-cache if flag "append_before_attn" is set.
if (append_before_attn_) {
Expand Down Expand Up @@ -2202,7 +2202,7 @@ class PagedAttentionKVCacheObj : public AttentionKVCacheObj {
}
double coalesce_ratio = 1.0 * page_counter_uncoalesced / page_counter_coalesced;
// Do not coalesce and use batch decode kernel when coalesce ratio is small.
bool use_decode_kernel = is_decode_request_ && coalesce_ratio < 1.1;
bool use_decode_kernel = is_decode_request_ && coalesce_ratio < 32;
return {use_decode_kernel || !enable_coalesce ? uncoalesced_block_ids : coalesced_block_ids,
use_decode_kernel};
}
Expand Down