[Relax][PyTorch] tests for additional modules with exported program translator #17862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugolatendresse
changed the title
hugolatendresse
changed the title
Contributor
Author
|
cc @MasterJH5574 @tlopex this is ready for review |
MasterJH5574
approved these changes
Apr 21, 2025
Contributor
|
Looks like there's a conflict to resolve before we can merge this PR. |
Contributor
Author
|
This PR needs changes in light of comments in #17863. Setting back to draft for now. |
Contributor
Author
|
Replacing this PR with #17907, where I moved the e2e tests to nightly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested the ingestion and correctness of several PyTorch modules using the exported program translator. The tests in this PR passed out of the box so I'm including them as additional unit tests. The tests for the modules below failed and so will be addressed in future PRs:
[ ] nn.ConvTranspose1d
[ ] nn.ConvTranspose2d
[x] nn.CrossEntropyLoss #17863
[ ] Tensor.scatter
[ ] Tensor.is_floating_point
[ ] torch.lerp