Add registion for the operator asin and acos in llvm #17945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hzfengsy
approved these changes
May 12, 2025
ShiboXing
pushed a commit
to ShiboXing/tvm
that referenced
this pull request
Aug 10, 2025
* register operator asin and acos * Update intrin_rule_llvm.cc * Update intrin_rule_llvm.cc * fix atan * Update intrin_rule_llvm.cc * Update intrin_rule_llvm.cc * Update test_tir_intrin.py * Update test_tir_intrin.py * Update test_tir_intrin.py * Update test_frontend_onnx.py * Update test_frontend_onnx.py * Update test_frontend_onnx.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #17944.
The PR is designed to support the operators
asin/acos/atan;Since the Taylor implementation algorithm is not perfect, we use
1e-3tolerance for asin/acos/atan tests to account for the precision loss from the Taylor approximation.Here, I also added a
TODOlabel to improve the precision of algorithms in the future.Meanwhile, do you have any recommendations for improving the precision of the
asin/acos/atanoperators?cc @Hzfengsy @tqchen @Lunderberg @mshr-h