Skip to content

[Relax][PyTorch] Add decomposed operator support for Conv #18433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tlopex merged 1 commit into from
Nov 12, 2025
Merged

[Relax][PyTorch] Add decomposed operator support for Conv #18433

tlopex merged 1 commit into from
Nov 12, 2025

Conversation

@guan404ming
Copy link
Member

@guan404ming guan404ming commented Nov 12, 2025 •
edited
Loading

Related Issue

#18401

Why

  • When run_ep_decomposition=True is enabled, PyTorch decomposes high-level operators like conv2d.default into
    lower-level convolution.default, which is not supported yet.

How

  • Added _convolution() method in base_fx_graph_translator.py to handle the generic aten.convolution.default operator
  • Updated test_keep_params to use run_ep_decomposition=True

@guan404ming guan404ming force-pushed the add-decomposed-support-for-conv branch from 6324760 to 83c1772 Compare November 12, 2025 03:52
@guan404ming guan404ming marked this pull request as ready for review November 12, 2025 05:40
@guan404ming
Copy link
Member Author

guan404ming commented Nov 12, 2025 •
edited
Loading

cc @tlopex @mshr-h

tlopex
tlopex approved these changes Nov 12, 2025
View reviewed changes
Copy link
Member

@tlopex tlopex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@tlopex tlopex merged commit ce5f287 into apache:main Nov 12, 2025
15 checks passed
@guan404ming guan404ming changed the title [Relax][PyTorch] Add support for decomposed operators and fix IR of ops tests [Relax][PyTorch] Add decomposed operator support for Conv Nov 14, 2025
@ysh329 ysh329 mentioned this pull request Feb 1, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tlopex tlopex tlopex approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@guan404ming @tlopex