Skip to content

Conversation

@srkreddy1238
Copy link
Contributor

Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from others in the community.

Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other parts looks good

@srkreddy1238
Copy link
Contributor Author

cc @junrushao1994 please have another look.

@yzhliu yzhliu self-assigned this Oct 11, 2018
@yzhliu yzhliu added status: review in progress status: need update need update based on feedbacks labels Oct 11, 2018
@srkreddy1238 srkreddy1238 force-pushed the ir-ops branch 3 times, most recently from 44f33a7 to 96b6946 Compare October 18, 2018 03:08
@tqchen
Copy link
Member

tqchen commented Oct 18, 2018

@junrushao1994 @srkreddy1238 can you followup again on this?

@srkreddy1238
Copy link
Contributor Author

@junrushao1994 & @tqchen have a look again.

Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tqchen
Copy link
Member

tqchen commented Oct 21, 2018

please rebase against master and note the changes in #1934

@srkreddy1238
Copy link
Contributor Author

@tqchen have a look

Copy link
Member

@tqchen tqchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last comment, thanks for being patient during the review process

@srkreddy1238 srkreddy1238 force-pushed the ir-ops branch 2 times, most recently from 93ca456 to 3941864 Compare October 24, 2018 06:01
@srkreddy1238
Copy link
Contributor Author

cc @tqchen pls have a look at the alpha equal for Div operator too.

@srkreddy1238 srkreddy1238 force-pushed the ir-ops branch 2 times, most recently from 3bbda52 to e6e95da Compare October 25, 2018 11:31
@srkreddy1238
Copy link
Contributor Author

cc @tqchen

@tqchen tqchen merged commit e6e9b37 into apache:master Oct 26, 2018
@tqchen
Copy link
Member

tqchen commented Oct 26, 2018

Thanks @srkreddy1238 @junrushao1994 @yzhliu this is merged

eqy pushed a commit to eqy/tvm that referenced this pull request Oct 29, 2018
FrozenGene pushed a commit to FrozenGene/tvm that referenced this pull request Dec 27, 2018
wweic pushed a commit to neo-ai/tvm that referenced this pull request Feb 20, 2019
wweic pushed a commit to neo-ai/tvm that referenced this pull request Feb 20, 2019
@srkreddy1238 srkreddy1238 deleted the ir-ops branch January 24, 2020 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants