Fix infinite recursion in get_const_tuple when passed non-tuple input

[jikechao]

Fix #18765.

This PR fixes an infinite recursion bug in topi.utils.get_const_tuple when the function is called with a non-tuple input (e.g., te.Tensor, tvm.tir.PrimExpr).

I added a type check at function entry to handle non-tuple/list inputs.

[gemini-code-assist]

Summary of Changes

Hello @jikechao, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical bug in the topi.utils.get_const_tuple function by preventing infinite recursion. The change ensures that the function can robustly handle various input types, specifically non-tuple or non-list objects, without crashing, thereby enhancing the stability and reliability of the TVM framework.

Highlights

• Infinite Recursion Fix: Addressed an infinite recursion bug in topi.utils.get_const_tuple that occurred when non-tuple or non-list inputs (e.g., te.Tensor, tvm.tir.PrimExpr) were provided.
• Input Type Handling: Implemented a type check at the function entry point of get_const_tuple to gracefully handle inputs that are not tuples or lists, returning them as a single-element tuple.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• python/tvm/topi/utils.py
  • Added a type check to get_const_tuple to handle non-tuple/list inputs gracefully.

Activity

• No specific activity (comments, reviews, progress) has been provided in the context for this pull request.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses an infinite recursion bug in get_const_tuple for non-tuple inputs. The proposed fix is correct in stopping the recursion. However, it introduces a backward-incompatible change for inputs like te.Tensor. My review includes a suggestion to handle this, preserving the old behavior for tensors while still fixing the bug. This would make the fix safer and less disruptive.

[gemini-code-assist]

This change correctly fixes the infinite recursion bug. However, it introduces a backward-incompatible change for te.Tensor inputs. Previously, get_const_tuple(tensor) would effectively process the tensor's shape. With this change, it will return (tensor,). While the previous behavior was undocumented, breaking it might cause issues for existing code.

To maintain backward compatibility for te.Tensor while still fixing the recursion bug for other non-tuple types like PrimExpr, consider handling te.Tensor as a special case. For example, you could modify the logic to be something like:

    if not isinstance(in_tuple, (tuple, list)):
        if isinstance(in_tuple, te.Tensor):
            in_tuple = in_tuple.shape
        else:
            return (in_tuple,)