Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Oct 11, 2018

Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from others in the community.

@ghost
Copy link
Author

ghost commented Oct 11, 2018

@tqchen @yzhliu @srkreddy1238 Could you please suggest the reviewers for this PR? I have taken care of comments from Siva.

@ghost
Copy link
Author

ghost commented Oct 12, 2018

Please also have a look at the fix done in #1894 related to usage of shape dict only when the shape operator is converted into NNVM symbol inside tensorflow.py

@ghost ghost changed the title Support for Shape and Reshape in TensorFlow frontend [TensorFlow] Support for Shape and Reshape in TensorFlow frontend Oct 12, 2018
@tqchen
Copy link
Member

tqchen commented Oct 24, 2018

please rebase against the current master @wweic @srkreddy1238 please review

@srkreddy1238
Copy link
Contributor

Reshape require further handling to support InceptionV4 & ResnetV2.
#1923 handles it as required and is verified too.

@wweic
Copy link
Contributor

wweic commented Oct 24, 2018

I plan to look into #1864, this PR seems to be in the same area. Could you share what testing have you done for this PR? The reason I ask is because I'm not able to pass all unit tests in nnvm/tests/python/frontend/tensorflow/test_forward.py(even in master branch!). We should fix the failure if that's the case and enable tests under nnvm/tests/python/frontend/* in CI.

@ghost
Copy link
Author

ghost commented Oct 25, 2018

@wweic Please look #1923 as pointed by Siva above. They are comprehensive changes and superset of this PR. I will close this PR (#1884 ).

@ghost ghost closed this Oct 25, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants