Skip to content

[Relay] Fix IncompleteType Alpha Equality Checking #1901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joshpoll wants to merge 2 commits into from
Closed

[Relay] Fix IncompleteType Alpha Equality Checking #1901

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ffabe67
[Relay] Fix IncompleteType Alpha Equality Checking
joshpoll Oct 14, 2018
946f659
update alpha equality tests
joshpoll Oct 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/relay/pass/alpha_eq.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ struct TypeAlphaEq : TypeVisitor<const Type&> {

void VisitType_(const IncompleteTypeNode* bt1, const Type& t2) final {
if (const IncompleteTypeNode* bt2 = t2.as<IncompleteTypeNode>()) {
equal = equal && bt1 == bt2;
equal = equal && bt1->kind == bt2->kind;
return;
} else {
equal = false;
Expand Down
5 changes: 1 addition & 4 deletions tests/python/relay/test_pass_alpha_equal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,8 @@ def test_incomplete_type_alpha_equal():
t2 = relay.IncompleteType(relay.Kind.Type)
t3 = relay.IncompleteType(relay.Kind.Type)

# only equal when there is pointer equality
assert t2 == t2
assert t1 == t1
assert t1 != t2
assert t2 != t3
assert t2 == t3


def test_type_param_alpha_equal():
Expand Down