Skip to content

Conversation

@vinx13
Copy link
Member

@vinx13 vinx13 commented Oct 23, 2018

some data when batch = 32

model time(ms) TVM time(ms) tensorRT
vgg-16 41.83 35.66
resnet-50 19.75 18.13
inception-v3 41.41 18.77

inception-v3 is still very slow, although it is 2x speedup in this PR. We can follow up on this when we have group convolution.

cc @merrymercy @tqchen

@vinx13 vinx13 force-pushed the feature/batched_conv2d branch from f5d570e to 4d09d7d Compare October 23, 2018 07:08
@tqchen
Copy link
Member

tqchen commented Oct 23, 2018

@masahi @nishi-t @anijain2305 please review

@masahi
Copy link
Member

masahi commented Oct 24, 2018

It is better to add test cases for batch size > 1, such as batch size = 8, 16, 32, etc.

@tqchen tqchen added status: need update need update based on feedbacks and removed status: need review labels Oct 24, 2018
@tqchen tqchen merged commit 42dc24a into apache:master Oct 27, 2018
@tqchen
Copy link
Member

tqchen commented Oct 27, 2018

Thanks @masahi for helpful reviews, Thanks @vinx13 for contribution, this is now merged

@tqchen tqchen added status: accepted and removed status: need update need update based on feedbacks labels Oct 27, 2018
eqy pushed a commit to eqy/tvm that referenced this pull request Oct 29, 2018
FrozenGene pushed a commit to FrozenGene/tvm that referenced this pull request Dec 27, 2018
wweic pushed a commit to neo-ai/tvm that referenced this pull request Feb 20, 2019
wweic pushed a commit to neo-ai/tvm that referenced this pull request Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants