Skip to content

Conversation

@siju-samuel
Copy link
Member

Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers.

@siju-samuel
Copy link
Member Author

https://discuss.tvm.ai/t/relay-concatenate-for-incompletetypenode/1045

This issue exists for Squeezenet and InceptionV3,
so this testcase is not enabled now.

@siju-samuel
Copy link
Member Author

@eqy @Huyuwei @slyubomirsky please help to review. TIA

@siju-samuel siju-samuel force-pushed the relay_testing_port branch 4 times, most recently from 774285f to b77a8ca Compare October 31, 2018 02:50
@siju-samuel
Copy link
Member Author

@eqy @Huyuwei @slyubomirsky @tqchen please help to review.

padding=pad,
name='%s%s_conv1' % (name, suffix))

#bn = sym.batch_norm(data=conv, name='%s%s_batchnorm' % (name, suffix), epsilon=2e-5)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the comment, so as those below.

@tqchen
Copy link
Member

tqchen commented Nov 16, 2018

@yzhliu can you do a follow-up review and merge it if it is OK?

@tqchen tqchen merged commit b1cf70a into apache:master Nov 24, 2018
@tqchen
Copy link
Member

tqchen commented Nov 25, 2018

Thanks, @siju-samuel I merged this in. However, the current code still has problems that need to be fixed, see #2163 on followups

FrozenGene pushed a commit to FrozenGene/tvm that referenced this pull request Dec 27, 2018
wweic pushed a commit to neo-ai/tvm that referenced this pull request Feb 20, 2019
wweic pushed a commit to neo-ai/tvm that referenced this pull request Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants