Add Split and realdiv op support #2123

Rasterer · 2018-11-16T03:51:58Z

Add Split and realdiv op support
Fix the pad calculation in the case of dilated convolution

@srkreddy1238 @nishi-t please help review, thanks

alexeyr · 2018-11-16T07:07:20Z

For split, my pull request covers SplitV (with list of split sizes passed) as well: #2105.

yzhliu · 2018-11-20T02:32:11Z

Thanks for contributing, please request review from Reviewers

srkreddy1238 · 2018-11-20T06:40:54Z

nnvm/python/nnvm/frontend/tensorflow.py


-            pad_v = _get_pad_pair(in_h, kernel_h, stride_h)
-            pad_h = _get_pad_pair(in_w, kernel_w, stride_w)
+            dilation_h = attr['dilations'][0]


@Rasterer Can you explain this change ?

Please refer to https://github.com/dmlc/tvm/blob/master/nnvm/src/top/nn/convolution.cc#L100 for the affect of dilation on output size. Dilated conv always can be simulated by a normal conv with dilated kernel. So I use dilated kernel size for pad calculation instead.

@srkreddy1238 any more comment about this?

yzhliu · 2018-11-26T22:06:42Z

@srkreddy1238 could you verify the changes?

srkreddy1238

Thanks @Rasterer. sorry about the delay, few comments before concluding the PR.

srkreddy1238 · 2018-12-05T15:26:11Z

nnvm/tests/python/frontend/tensorflow/test_forward.py


+#######################################################################
+# Split
+# ------


Under line up to the string pls.

@srkreddy1238 updated

srkreddy1238 · 2018-12-05T15:28:38Z

nnvm/tests/python/frontend/tensorflow/test_forward.py

+# Split
+# ------
+
+def _test_split(in_shape, axis, num_split, dtype):


Can you add another test case with split followed by concat ?

@srkreddy1238 updated

* Add Split and realdiv op support * Fix the pad calculation in the case of dilated convolution

srkreddy1238

Thanks @Rasterer LGTM.

srkreddy1238 · 2018-12-06T09:32:27Z

cc @yzhliu

yzhliu · 2018-12-06T17:51:29Z

Thanks @Rasterer @srkreddy1238 . This is now merged.

* Add Split and realdiv op support * Fix the pad calculation in the case of dilated convolution

commit f347b52 Author: Yong Wu <yongwu@amazon.com> Get tags of saved model automatically commit 916576c Author: Zhi Chen <chzhi@amazon.com> Support TensorFlow saved model TF parser: return the consistent error message to error handler commit f1782f3 Author: Yong Wu <yongwu@amazon.com> Add tf parser wrapper, infer shape automatically commit 76188a4 Author: Siva <sivar.b@huawei.com> [NNVM][TENSORFLOW] bugfix. (apache#2444) commit 6737739 Author: Ashutosh Parkhi <ashutosh.parkhi@imgtec.com> [Tensorflow] Support for Crop (apache#2285) commit f6c3f99 Author: Alexey Romanov <alexey.v.romanov@gmail.com> [FRONTEND][TENSORFLOW] Use input shapes directly instead of 1-element lists (apache#2242) commit e5d92e1 Author: Dominic Symes <36929632+dominicsymes@users.noreply.github.com> [FRONTEND][TENSORFLOW] Bugfix (apache#2326) commit 00d509d Author: Alexey Romanov <alexey.v.romanov@gmail.com> [FRONTEND][TENSORFLOW] Support Unstack and Split (apache#2105) commit df9d3ad Author: Siva <sivar.b@huawei.com> [FRONTEND][TENSORFLOW] Bugfix (apache#2267) commit d1a0c90 Author: Zhebin Jin <zhebin.jzb@alibaba-inc.com> [FRONTEND][TENSORFLOW]Add Split and realdiv op support (apache#2123) * Add Split and realdiv op support * Fix the pad calculation in the case of dilated convolution

commit 76188a4 Author: Siva sivar.b@huawei.com [NNVM][TENSORFLOW] bugfix. (apache#2444) commit 6737739 Author: Ashutosh Parkhi ashutosh.parkhi@imgtec.com [Tensorflow] Support for Crop (apache#2285) commit f6c3f99 Author: Alexey Romanov alexey.v.romanov@gmail.com [FRONTEND][TENSORFLOW] Use input shapes directly instead of 1-element lists (apache#2242) commit e5d92e1 Author: Dominic Symes 36929632+dominicsymes@users.noreply.github.com [FRONTEND][TENSORFLOW] Bugfix (apache#2326) commit 00d509d Author: Alexey Romanov alexey.v.romanov@gmail.com [FRONTEND][TENSORFLOW] Support Unstack and Split (apache#2105) commit df9d3ad Author: Siva sivar.b@huawei.com [FRONTEND][TENSORFLOW] Bugfix (apache#2267) commit d1a0c90 Author: Zhebin Jin zhebin.jzb@alibaba-inc.com [FRONTEND][TENSORFLOW]Add Split and realdiv op support (apache#2123) * Add Split and realdiv op support * Fix the pad calculation in the case of dilated convolution

* [FRONTEND][TENSORFLOW] Enhance with left over patches from NNVM. commit 76188a4 Author: Siva sivar.b@huawei.com [NNVM][TENSORFLOW] bugfix. (#2444) commit 6737739 Author: Ashutosh Parkhi ashutosh.parkhi@imgtec.com [Tensorflow] Support for Crop (#2285) commit f6c3f99 Author: Alexey Romanov alexey.v.romanov@gmail.com [FRONTEND][TENSORFLOW] Use input shapes directly instead of 1-element lists (#2242) commit e5d92e1 Author: Dominic Symes 36929632+dominicsymes@users.noreply.github.com [FRONTEND][TENSORFLOW] Bugfix (#2326) commit 00d509d Author: Alexey Romanov alexey.v.romanov@gmail.com [FRONTEND][TENSORFLOW] Support Unstack and Split (#2105) commit df9d3ad Author: Siva sivar.b@huawei.com [FRONTEND][TENSORFLOW] Bugfix (#2267) commit d1a0c90 Author: Zhebin Jin zhebin.jzb@alibaba-inc.com [FRONTEND][TENSORFLOW]Add Split and realdiv op support (#2123) * Add Split and realdiv op support * Fix the pad calculation in the case of dilated convolution * * review comments * * resnet fix. * * review comments

…che#2757) * [FRONTEND][TENSORFLOW] Enhance with left over patches from NNVM. commit 76188a4 Author: Siva sivar.b@huawei.com [NNVM][TENSORFLOW] bugfix. (apache#2444) commit 6737739 Author: Ashutosh Parkhi ashutosh.parkhi@imgtec.com [Tensorflow] Support for Crop (apache#2285) commit f6c3f99 Author: Alexey Romanov alexey.v.romanov@gmail.com [FRONTEND][TENSORFLOW] Use input shapes directly instead of 1-element lists (apache#2242) commit e5d92e1 Author: Dominic Symes 36929632+dominicsymes@users.noreply.github.com [FRONTEND][TENSORFLOW] Bugfix (apache#2326) commit 00d509d Author: Alexey Romanov alexey.v.romanov@gmail.com [FRONTEND][TENSORFLOW] Support Unstack and Split (apache#2105) commit df9d3ad Author: Siva sivar.b@huawei.com [FRONTEND][TENSORFLOW] Bugfix (apache#2267) commit d1a0c90 Author: Zhebin Jin zhebin.jzb@alibaba-inc.com [FRONTEND][TENSORFLOW]Add Split and realdiv op support (apache#2123) * Add Split and realdiv op support * Fix the pad calculation in the case of dilated convolution * * review comments * * resnet fix. * * review comments

yzhliu added the status: need review label Nov 20, 2018

Rasterer force-pushed the split_div branch from daecfd9 to 7707d46 Compare November 20, 2018 03:38

srkreddy1238 requested changes Nov 20, 2018

View reviewed changes

srkreddy1238 requested changes Dec 5, 2018

View reviewed changes

srkreddy1238 mentioned this pull request Dec 5, 2018

[FRONTEND][TENSORFLOW] Support Unstack and Split #2105

Merged

[FRONTEND][TENSORFLOW]Add Split and realdiv op support

45f88e2

* Add Split and realdiv op support * Fix the pad calculation in the case of dilated convolution

Rasterer force-pushed the split_div branch from 354916f to 45f88e2 Compare December 6, 2018 03:37

srkreddy1238 approved these changes Dec 6, 2018

View reviewed changes

yzhliu approved these changes Dec 6, 2018

View reviewed changes

yzhliu merged commit d1a0c90 into apache:master Dec 6, 2018

Rasterer deleted the split_div branch December 7, 2018 01:02

FrozenGene pushed a commit to FrozenGene/tvm that referenced this pull request Dec 27, 2018

[FRONTEND][TENSORFLOW]Add Split and realdiv op support (apache#2123)

467f3c6

* Add Split and realdiv op support * Fix the pad calculation in the case of dilated convolution

wweic pushed a commit to neo-ai/tvm that referenced this pull request Feb 20, 2019

[FRONTEND][TENSORFLOW]Add Split and realdiv op support (apache#2123)

f78958d

* Add Split and realdiv op support * Fix the pad calculation in the case of dilated convolution

wweic pushed a commit to neo-ai/tvm that referenced this pull request Feb 20, 2019

[FRONTEND][TENSORFLOW]Add Split and realdiv op support (apache#2123)

2c0d3fa

* Add Split and realdiv op support * Fix the pad calculation in the case of dilated convolution

srkreddy1238 mentioned this pull request Mar 9, 2019

[FRONTEND][TENSORFLOW] Enhance with left over patches from NNVM. #2757

Merged

Add Split and realdiv op support #2123

Add Split and realdiv op support #2123

Uh oh!

Conversation

Rasterer commented Nov 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexeyr commented Nov 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yzhliu commented Nov 20, 2018

Uh oh!

srkreddy1238 Nov 20, 2018

Choose a reason for hiding this comment

Uh oh!

Rasterer Nov 20, 2018

Choose a reason for hiding this comment

Uh oh!

Rasterer Nov 26, 2018

Choose a reason for hiding this comment

Uh oh!

yzhliu commented Nov 26, 2018

Uh oh!

srkreddy1238 left a comment

Choose a reason for hiding this comment

Uh oh!

srkreddy1238 Dec 5, 2018

Choose a reason for hiding this comment

Uh oh!

Rasterer Dec 6, 2018

Choose a reason for hiding this comment

Uh oh!

srkreddy1238 Dec 5, 2018

Choose a reason for hiding this comment

Uh oh!

Rasterer Dec 6, 2018

Choose a reason for hiding this comment

Uh oh!

srkreddy1238 left a comment

Choose a reason for hiding this comment

Uh oh!

srkreddy1238 commented Dec 6, 2018

Uh oh!

yzhliu commented Dec 6, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Rasterer commented Nov 16, 2018 •

edited

Loading

alexeyr commented Nov 16, 2018 •

edited

Loading