Relay reshape reshape_like compute and schedule #2159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@jroesch, @MarisaKirisame @tqchen @yzhliu Please help to review this PR. Thanks |
MarisaKirisame
approved these changes
Nov 22, 2018
|
|
||
| func = relay.Function([x, y], z) | ||
|
|
||
| for target, ctx in ctx_list(): |
Contributor
There was a problem hiding this comment.
this code appear in other test as well. should we refactor it to a common facility?
Member
|
Looks good to me, could use this for #2144, I copied the compute to my branch for the time being. |
jroesch
added a commit
to jroesch/tvm
that referenced
this pull request
Nov 25, 2018
Member
|
The reshape implementation has some issues, due to the possibility of newshape containing negative number, we need to use the type of output instead to implement this |
Member
|
Given the interest of recent changes, I will merge this in and amend in the followup PR #2163. Thanks @siju-samuel @MarisaKirisame @jroesch |
Member
|
please do refer to the #2163 for the necessary changes and use that as reference for future codes :) |
jroesch
added a commit
to jroesch/tvm
that referenced
this pull request
Nov 26, 2018
jroesch
added a commit
to jroesch/tvm
that referenced
this pull request
Nov 26, 2018
jroesch
added a commit
to jroesch/tvm
that referenced
this pull request
Dec 1, 2018
jroesch
added a commit
to jroesch/tvm
that referenced
this pull request
Dec 3, 2018
jroesch
added a commit
to jroesch/tvm
that referenced
this pull request
Dec 3, 2018
jroesch
added a commit
to jroesch/tvm
that referenced
this pull request
Dec 3, 2018
Repair imports First test passes Fix bug in axes passing Add implementations for upsampling and pad Add support for bias with conv ops Rebase fixup Borrow the reshape changes while waiting on apache#2159 Debugging tests Repair after rebase Refactor to use common functionality Fix helper func Remove final eval Remove some debuggin Remove unecessary ws change Fix multiple outputs Tests pass Enable all tests Rebase repair Fix last test case Fix last test case All tests but RNNs pass Fix tests Remove final eval Reformat Fix bugs in MxNet Fix 3.5 support in Relay, and rename Factor common functionality into one file Apply most of code review Fix linting Fix NNVM linting Fix test error Fix MLP test Fix linting error One more linting issue Clean up diff and fix bugs Retrigger disable MLP test Retrigger Retrigger Roll back NNVM change Retrigger Retrigger Retrigger
jroesch
added a commit
to jroesch/tvm
that referenced
this pull request
Dec 3, 2018
Repair imports First test passes Fix bug in axes passing Add implementations for upsampling and pad Add support for bias with conv ops Rebase fixup Borrow the reshape changes while waiting on apache#2159 Debugging tests Repair after rebase Refactor to use common functionality Fix helper func Remove final eval Remove some debuggin Remove unecessary ws change Fix multiple outputs Tests pass Enable all tests Rebase repair Fix last test case Fix last test case All tests but RNNs pass Fix tests Remove final eval Reformat Fix bugs in MxNet Fix 3.5 support in Relay, and rename Factor common functionality into one file Apply most of code review Fix linting Fix NNVM linting Fix test error Fix MLP test Fix linting error One more linting issue Clean up diff and fix bugs Retrigger disable MLP test Retrigger Retrigger Roll back NNVM change Retrigger Retrigger Retrigger
FrozenGene
pushed a commit
to FrozenGene/tvm
that referenced
this pull request
Dec 27, 2018
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 20, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2051
Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers.