Add a the ability to trigger debugging in the interpreter without recompiling #2219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jroesch
force-pushed
the
interp-debug
branch
from
25bde54 to
4a0e867
Compare
Member
Author
|
This is ready for review @MarisaKirisame @joshpoll @tqchen |
joshpoll
reviewed
Dec 19, 2018
joshpoll
reviewed
Dec 19, 2018
joshpoll
reviewed
Dec 19, 2018
joshpoll
reviewed
Dec 19, 2018
joshpoll
reviewed
Dec 19, 2018
joshpoll
reviewed
Dec 19, 2018
joshpoll
reviewed
Dec 19, 2018
joshpoll
reviewed
Dec 19, 2018
joshpoll
reviewed
Dec 19, 2018
joshpoll
reviewed
Dec 19, 2018
zhiics
reviewed
Dec 19, 2018
Co-Authored-By: jroesch <roeschinc@gmail.com>
Co-Authored-By: jroesch <roeschinc@gmail.com>
Co-Authored-By: jroesch <roeschinc@gmail.com>
Co-Authored-By: jroesch <roeschinc@gmail.com>
tqchen
requested changes
Dec 23, 2018
src/relay/op/debug.cc
Outdated
| .add_argument("program", "Tuple", "The program to execute before debugging.") | ||
| .set_support_level(1) | ||
| .add_type_rel("Debug", IdentityRel) | ||
| .set_attr<TOpPattern>("TOpPattern", kInjective) |
Member
There was a problem hiding this comment.
mark this as opaque, so debug won't be fused with other ops.
tqchen
approved these changes
Dec 25, 2018
Member
|
Thanks, @jroesch @zhiics @joshpoll @MarisaKirisame , this is now merged |
tqchen
added
status: accepted
and removed
status: need update
FrozenGene
pushed a commit
to FrozenGene/tvm
that referenced
this pull request
Dec 27, 2018
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 20, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an operator
debug(i.edebug<T>(t) : T), which triggers the interpreter's debugger. The function is an identity function which pauses execution with the ability to inspect the current expression (the argument to debug) as well as the evaluation stack.I will add a little more support for visualizing the execution and stepping through execution.
cc @ZihengJiang