Fix missing sigmoid intrinsic in C++ #2231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergei-mironov
force-pushed
the
sigmoid
branch
from
72e6e09 to
d173055
Compare
Contributor
Author
sergei-mironov
force-pushed
the
sigmoid
branch
3 times, most recently
from
bbd535e to
a867f53
Compare
tqchen
requested changes
Dec 5, 2018
sergei-mironov
force-pushed
the
sigmoid
branch
from
a867f53 to
fd5fc73
Compare
tqchen
approved these changes
Dec 7, 2018
sergei-mironov
added a commit
to sergei-mironov/tvm
that referenced
this pull request
Dec 9, 2018
FrozenGene
pushed a commit
to FrozenGene/tvm
that referenced
this pull request
Dec 27, 2018
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 20, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves missing sigmoid intrinsic problem, visible when running C++ program, e.g. [1]. Python code is not affected because python libraries used to register their own fallback as follows:
https://github.com/dmlc/tvm/blob/master/python/tvm/intrin.py#L497
We solve the problem by moving default intrinsic from Python to C++
[1] - https://gist.github.com/grwlf/fafa70cde68cfc33b11c36bd20b3e6f0 failed program