Small refactors and bug fixes. #2281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wweic
reviewed
Dec 13, 2018
src/relay/ir/expr.cc
Outdated
| bool FunctionNode::IsPrimitive() const { | ||
| NodeRef res = FunctionGetAttr(GetRef<Function>(this), "Primitive"); | ||
| const ir::IntImm* pval = res.as<ir::IntImm>(); | ||
| return pval && pval->value != 0; |
Contributor
There was a problem hiding this comment.
I think the indentation is not needed.
Contributor
There was a problem hiding this comment.
also fix this since it's failing CI lint test.
wweic
reviewed
Dec 13, 2018
| * | ||
| * \return Whether the function is primitive or not. | ||
| */ | ||
| bool IsPrimitive() const; |
Contributor
There was a problem hiding this comment.
Maybe replace this line with the new API?
https://github.com/dmlc/tvm/blob/01cfdb7ebcef0abc9282f68c3c4484974a6cc6e1/src/relay/pass/fuse_ops.cc#L702
Member
Author
There was a problem hiding this comment.
Yeah I was cherry-picking changes from an old branch 😄 got distracted at TVM conference while working on this PR.
Member
FrozenGene
pushed a commit
to FrozenGene/tvm
that referenced
this pull request
Dec 27, 2018
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 20, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm starting the process of upstreaming the bits and pieces of Relay we developed while prototyping new features. This PR is composed of bug fixes and refactors which should make it easier to port those changes.