[Relay][OP] Add cast op #2319
Merged
[Relay][OP] Add cast op #2319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Looks good to me, should we change the internal name from |
Member
Author
|
@jroesch Yes, I think so. Renamed it in the new commit. |
jroesch
approved these changes
Dec 26, 2018
FrozenGene
pushed a commit
to FrozenGene/tvm
that referenced
this pull request
Dec 27, 2018
* Add cast op * Rename dtype_cast to cast * Add additional safety check for String2TVMType * Add missing relay op docs
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 20, 2019
* Add cast op * Rename dtype_cast to cast * Add additional safety check for String2TVMType * Add missing relay op docs
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 20, 2019
* Add cast op * Rename dtype_cast to cast * Add additional safety check for String2TVMType * Add missing relay op docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I understand that we have x.astype(dtype) to cast type. But I think it's good to also have relay.cast as another API for cast operator. Besides adding cast op, this PR also includes