[RELAY][Errors][WIP] Add descriptive errors for Relay #2341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| mutable ErrorReporter err_reporter; | ||
|
|
||
| mutable GlobalVar entry_func; |
| }); | ||
|
|
||
|
|
||
|
|
| Error err("failed to unify"); | ||
| err.sp = span; | ||
| FatalError(err); | ||
| // << "Error unifying `" |
Contributor
There was a problem hiding this comment.
put into err or delete the comment
| this->PrintCallAttrs(op->op, op->attrs, stream_); | ||
| stream_ << ")"; | ||
| this->PrintEndInst(""); | ||
| this->PrintEndInst(";"); |
Contributor
There was a problem hiding this comment.
refactor into two method
| auto e = TypeInferencer(mod).Infer(expr); | ||
| Expr InferType(const Expr& expr, const Module& m) { | ||
| Module mod = m; | ||
| if (!mod.defined()) |
Contributor
There was a problem hiding this comment.
are you sure we need this? I think tvm ffi will init this to a empty Module.
Member
Author
|
Closing in favor of #2408, will revive span based errors in a follow-up PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the ability to generate descriptive errors for Relay. An error can be reported on a
tam::relay::Spanwhich corresponds to a source location in the original program.For programs which are built programmatically we recover a representation of the program which is useful for error reporting. We generate this representation using the text printer and then parse it to recover the span information.
Once we have done this we can precisely mark an error on the original program, for example report the operator invocation which has a type error.
My goal is that we will only need to do this once when inputting the program, and store the program fragment in a
tvm::relay::Module.This PR lays the initial groundwork to do this kind of error reporting.
I will do more experimentation and clean up work before this is ready to merge.
One large challenge is related to vars, due to vars appearing many times in the program, but only being allocated once we can not easily track the span information correctly for it using Relay's current representation. If we put the programs into ANF, we can provide very clear errors, but I think we will need to revisit how we track span information, but this will enable us to have informative errors in the mean time.
cc @joshpoll @MarisaKirisame @tqchen @ZihengJiang