[RELAY][EXPR] Make const numpy consistent #2349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I think this is a great change. I've run into this problem multiple times, and having a consistent default would be good. |
FrozenGene
pushed a commit
to FrozenGene/tvm
that referenced
this pull request
Jan 10, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 20, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 20, 2019
tqchen
added a commit
to tqchen/tvm
that referenced
this pull request
Mar 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PR tries to rectify the
relay.constAPI, as well as tvm's low-level API to be numpy consistent. This means 1 integer now maps to int64 and float 1.0 now maps to float64.Although this choice will make some uncomfortableness in the short term, hopefully this will be better for the users in the long run.
cc @were @jroesch