Skip to content

Conversation

@ehsanmok
Copy link
Contributor

@ehsanmok ehsanmok commented Jan 6, 2019

Per discussion #2318 required for frontend PR.

@ehsanmok
Copy link
Contributor Author

ehsanmok commented Jan 6, 2019

@tqchen python frontend gpu error ?!

@tqchen
Copy link
Member

tqchen commented Jan 8, 2019

@ehsanmok Given that we are a bit limited in CI resource, let us put the test script on the same stage as the normal rust test

@tqchen tqchen self-assigned this Jan 8, 2019
@ehsanmok
Copy link
Contributor Author

ehsanmok commented Jan 8, 2019

@tqchen I think normal (runtime) Rust doesn't need unpack_lib here whereas frontend Rust needs unpack_lib('cpu', tvm_multilib) (that's why the frontend PR build fails due to not finding libtvm_runtime.so). So if you want to make them all in the same test script, we can put runtime Rust where it has access to tvm_multilib and separate them when we have more resources later!

@tqchen
Copy link
Member

tqchen commented Jan 8, 2019

That works

@tqchen tqchen merged commit e36265b into apache:master Jan 9, 2019
tqchen added a commit that referenced this pull request Jan 9, 2019
FrozenGene pushed a commit to FrozenGene/tvm that referenced this pull request Jan 10, 2019
@ehsanmok ehsanmok deleted the rust_runtime_frontend_ci branch February 3, 2019 11:11
wweic pushed a commit to neo-ai/tvm that referenced this pull request Feb 20, 2019
wweic pushed a commit to neo-ai/tvm that referenced this pull request Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants