Skip to content

Conversation

@zhreshold
Copy link
Member

Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers.

Fix flaky tests by relaxing rtol and atol to 1e-5 which is reasonble for division or log operators.

Fix #2393, #2397

@zhreshold zhreshold changed the title relax rtol atol for div/log operators [FIX][unittest]relax rtol atol for div/log operators Jan 8, 2019
Copy link
Member

@icemelon icemelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tqchen tqchen merged commit a578475 into apache:master Jan 9, 2019
@tqchen
Copy link
Member

tqchen commented Jan 9, 2019

Thanks, @icemelon9 @zhreshold ! this is merged

tqchen added a commit that referenced this pull request Jan 9, 2019
@zhreshold zhreshold deleted the fix-flaky-test branch January 9, 2019 19:39
FrozenGene pushed a commit to FrozenGene/tvm that referenced this pull request Jan 10, 2019
wweic pushed a commit to neo-ai/tvm that referenced this pull request Feb 20, 2019
wweic pushed a commit to neo-ai/tvm that referenced this pull request Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants