[Doc][Tutorial] Add the instructions how to use contrib_spatial_pack #2427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merrymercy
reviewed
Jan 14, 2019
tutorials/autotvm/tune_nnvm_arm.py
Outdated
| for i, tsk in enumerate(reversed(tasks)): | ||
| prefix = "[Task %2d/%2d] " % (i+1, len(tasks)) | ||
|
|
||
| # if we want to use spatial pack for depthwise convolution |
Member
There was a problem hiding this comment.
can we move this after the if block of try_winograd?
Member
Author
There was a problem hiding this comment.
like 'try_winograd' for loop?
merrymercy
reviewed
Jan 14, 2019
tutorials/autotvm/tune_nnvm_arm.py
Outdated
| # create tuner | ||
| if tuner == 'xgb' or tuner == 'xgb-rank': | ||
| tuner_obj = XGBTuner(tsk, loss_type='rank') | ||
| if try_spatial_pack_depthwise and tsk.name == 'topi_nn_depthwise_conv2d_nchw': |
Member
There was a problem hiding this comment.
merge this if into the above one
Member
Author
There was a problem hiding this comment.
if we do like try_winograd for loop, I can not think of how to merge this in try_spatial_pack_depthwise for loop. Because we will init tunner in this loop.
Member
There was a problem hiding this comment.
We can do like
if try_spatial_pack_depthwise:
tuner = 'xgb_knob'
...
elif tuner == 'xgb_knob':
tuner_obj = XGBTuner(tsk, loss_type='rank', feature_type='knob')
Member
Author
There was a problem hiding this comment.
Thanks. I understand your meaning now.
Member
Author
There was a problem hiding this comment.
Have applied your suggestions. @merrymercy could you help review again?
merrymercy
approved these changes
Jan 15, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 20, 2019
…pache#2427) * [Doc][Tutorial] Add the instructions how to use contrib_spatial_pack * Update the code according suggestions
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 20, 2019
…pache#2427) * [Doc][Tutorial] Add the instructions how to use contrib_spatial_pack * Update the code according suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the follow up #2345.
@merrymercy please help to review.