[Relay] Fix handling a tuple node in op fusion #2433
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2431. In #2187, I was making a false assumption that the number of fields of a tuple nodes is the same as the number of parameters to a function containing the tuple. But this is not always the case, since the field value can be generated inside the function (or group).
For example, the gluon SSD model returns class ids, bounding box scores, and locations, shown below. After converting to Relay, the three outputs are put into a tuple. Three
slice_axisand the last tuple are put into the same group. This group has one parameter,result, but the tuple has three fields. This caused out of bounds access in #2431.@tqchen @kevinthesun @jroesch please review.