[ARITH] Analyzer Infra, ConstIntBound, Modular #2668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@were @ZihengJiang @sgrechanik-h @masahi @merrymercy please help review this PR |
8 tasks
tqchen
changed the title
Member
Author
|
@junrushao1994 can you help to take a look as well? |
junrushao
reviewed
Feb 28, 2019
| /*! \brief Number to represent +inf */ | ||
| static const constexpr int64_t kPosInf = std::numeric_limits<int64_t>::max(); | ||
| /*! \brief Number to represent -inf */ | ||
| static const constexpr int64_t kNegInf = -kPosInf; |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Member
Author
There was a problem hiding this comment.
to make sure -kPosInf == kNegInf
Member
Author
|
@junrushao1994, please https://docs.tvm.ai/contribute/code_review.html#approve-and-request-changes-explicitly, @derisavi @grwlf can you also help to take a look? |
junrushao
approved these changes
Mar 1, 2019
Member
junrushao
left a comment
junrushao
left a comment
There was a problem hiding this comment.
I took another look tonight, and felt good that finally we have this infra 👍
Member
|
@were might be interested |
Member
Author
|
Thanks, @junrushao1994 , this is now merged |
bwasti
pushed a commit
to facebookexperimental/tvm
that referenced
this pull request
Mar 6, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 9, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 12, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains one step of #2588