Skip to content

[Relay] Add ADTs to text format #3863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jroesch merged 29 commits into from
Sep 6, 2019
Merged

[Relay] Add ADTs to text format #3863

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
f246525
Getting closer to having ADT defs
weberlo Aug 23, 2019
511865c
ADT defs working probly
weberlo Aug 23, 2019
6df1be3
Match parsing basipally done
weberlo Aug 25, 2019
0f27b22
came to earth in a silver chrome UFO
weberlo Aug 26, 2019
ca9037b
match finished?
weberlo Aug 26, 2019
c1f3be8
All tests but newest are passing
weberlo Aug 26, 2019
259a686
ADT constructors work
weberlo Aug 27, 2019
8a0be59
Cleanup round 1
weberlo Aug 27, 2019
2ac4e93
Cleanup round 2
weberlo Aug 29, 2019
5d30aed
Cleanup round 3
weberlo Aug 29, 2019
b66e917
Cleanup round 4
weberlo Aug 30, 2019
3424198
Cleanup round 6
weberlo Aug 30, 2019
950ac0e
Cleanup round 7
weberlo Aug 30, 2019
bcb90bc
Lil grammar fix
weberlo Aug 30, 2019
9feb3be
Remove ANTLR Java files
weberlo Aug 30, 2019
95b9a9d
Lint roller
weberlo Aug 31, 2019
39fecdd
Lint roller
weberlo Aug 31, 2019
a8e128f
Address feedback
weberlo Aug 31, 2019
d31f625
Test completeness in match test
weberlo Aug 31, 2019
1def019
Remove unused imports
weberlo Aug 31, 2019
e1462d9
Lint roller
weberlo Sep 2, 2019
a5beffa
Switch to Rust-style ADT syntax
weberlo Sep 3, 2019
947a049
Lil fix
weberlo Sep 3, 2019
e85433f
Add dummy `extern type` handler
weberlo Sep 4, 2019
cab55de
Add type arg to test
weberlo Sep 4, 2019
eb43056
Update prelude semantic version
weberlo Sep 4, 2019
dfd53e1
Repair test
weberlo Sep 4, 2019
02b8150
Fix graph var handling in match
weberlo Sep 5, 2019
0ea6870
Revert 's/graph_equal/is_unifiable' change
weberlo Sep 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/tvm/relay/adt.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ class MatchNode : public ExprNode {
/*! \brief The match node clauses. */
tvm::Array<Clause> clauses;

/*! \brief Should this match be complete (cover all cases)?
/*! \brief Should this match be complete (cover all cases)?
* If yes, the type checker will generate an error if there are any missing cases.
*/
bool complete;
Expand Down
7 changes: 7 additions & 0 deletions include/tvm/relay/module.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,13 @@ class ModuleNode : public RelayNode {
*/
TVM_DLL TypeData LookupDef(const std::string& var) const;

/*!
* \brief Check if a global type definition exists
* \param var The name of the global type definition.
* \return Whether the definition exists.
*/
TVM_DLL bool HasDef(const std::string& var) const;

/*!
* \brief Look up a constructor by its tag.
* \param tag The tag for the constructor.
Expand Down
Loading