[TOPI] Move conv2d spatial pack schedule to dedicated file #3972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@vinx13 @merrymercy can you help managing this PR @jackwish please request reviewers by tagging folks next time :) |
Member
|
@jackwish Please fix lint error |
More schedules are making the conv2d.py file too large, so we'd like to move the spatial pack schedule to dedicated file before introducing NHWC schedule. No logic change in this patch.
Contributor
Author
merrymercy
approved these changes
Sep 25, 2019
Contributor
Author
|
thank you everyone! |
Member
|
@merrymercy just a reminder to change the status tag when we merge next time :) |
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Sep 30, 2019
More schedules are making the conv2d.py file too large, so we'd like to move the spatial pack schedule to dedicated file before introducing NHWC schedule. No logic change in this patch.
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Sep 30, 2019
More schedules are making the conv2d.py file too large, so we'd like to move the spatial pack schedule to dedicated file before introducing NHWC schedule. No logic change in this patch.
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Oct 1, 2019
More schedules are making the conv2d.py file too large, so we'd like to move the spatial pack schedule to dedicated file before introducing NHWC schedule. No logic change in this patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #3859 originally. As TVM adopts a squash style PR merging, I think it could be better to have standalone PR for changes like this to lease the review overhead.
Code logic should not be touched in this PR, so there could be a quick review :)
Would you lease take a look at this when available @merrymercy @vinx13 @yzhliu