Skip to content

[Rust] Fixes doctests in tvm-common sub crate #4114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
paddyhoran wants to merge 1 commit into from
Closed

[Rust] Fixes doctests in tvm-common sub crate #4114

paddyhoran wants to merge 1 commit into from

Conversation

@paddyhoran
Copy link
Contributor

@paddyhoran paddyhoran commented Oct 12, 2019

No description provided.

@paddyhoran
Copy link
Contributor Author

paddyhoran commented Oct 12, 2019

cc @nhynes

nhynes
nhynes reviewed Oct 12, 2019
View reviewed changes
Copy link
Member

@nhynes nhynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks a lot for the PR! A few tips

  • tvm_common shouldn't be imported by end-users
  • the TVM doc tests have been fixed in #2885 (along with several other improvements), if you'd like to give that a try

@paddyhoran
Copy link
Contributor Author

paddyhoran commented Oct 12, 2019

Ok, sounds good. Feel free to close. I guess 2885 is being blocked as it needs a review from a committer?

@nhynes
Copy link
Member

nhynes commented Oct 12, 2019 •
edited
Loading

(tentatively closing in favor of #2885)

@nhynes nhynes closed this Oct 12, 2019
@nhynes nhynes mentioned this pull request Oct 12, 2019
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nhynes nhynes nhynes left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@paddyhoran @nhynes