Skip to content

Conversation

@wweic
Copy link
Contributor

@wweic wweic commented Nov 13, 2019

This implements issue #4291.

I also applied the optimization in tensorflow converter that it keeps track of all the ins and outs of every tensor array, so we can determine if a tensor array is homogeneous or not. If true, we will directly extract the tensor out of the tensor_t object, and it will eliminate the trouble of reading from tensor_t.

We should do the same optimization in the future when we encounter operators that needs to use tensor_t objects.

cc @zhiics @icemelon9 @yongwww @kevinthesun @srkreddy1238 @jroesch @slyubomirsky

@wweic wweic force-pushed the record-tensor-array-rank branch 2 times, most recently from 3d462bb to 0641f12 Compare November 15, 2019 05:00
@wweic wweic force-pushed the record-tensor-array-rank branch from 221b4f0 to 15056b0 Compare December 7, 2019 16:35
@wweic
Copy link
Contributor Author

wweic commented Jan 7, 2020

I'll close the PR per discussion with @kevinthesun . We might want to detect static rank in the graph and specialize tensor array ops for the specific static rank, it will give most performant implementation. Generic tensor array might not be efficient enough for highly dynamic model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant